Skip to content

chore: bump thornode image: update to 1.0.28-23761879 (dev) - #85

Open
tiljrd wants to merge 1 commit into
devfrom
bump-thornode-1.0.28-23761879-dev
Open

chore: bump thornode image: update to 1.0.28-23761879 (dev)#85
tiljrd wants to merge 1 commit into
devfrom
bump-thornode-1.0.28-23761879-dev

Conversation

@tiljrd

@tiljrd tiljrd commented Jan 3, 2026 •
edited by qodo-code-review Bot
Loading

Copy link
Copy Markdown
Contributor

User description

Automated: bump image to tiljordan/thornode-forking:1.0.28-23761879 on base dev. Automated weekly bump.

PR Type

Other

Description

  • Update thornode-forking image from 1.0.25 to 1.0.28

  • Bump applied across all configuration files and examples

  • Automated weekly dependency update

Diagram Walkthrough

flowchart LR
  A["thornode-forking<br/>1.0.25-23761879"] -- "version bump" --> B["thornode-forking<br/>1.0.28-23761879"]
  B --> C["README.md"]
  B --> D["Configuration Files"]
  B --> E["Example Configs"]
  B --> F["Dockerfile"]
Loading

File Walkthrough
Relevant files
Configuration changes
README.md
Update thornode-forking image references                                 

README.md

  • Updated thornode-forking image version from 1.0.25 to 1.0.28 in
    forking configuration
  • Updated image version in participants section
 +2/-2     
cli-with-network.yaml
Update example CLI network configuration                                 

examples/cli-with-network.yaml

  • Updated thornode-forking image version from 1.0.25 to 1.0.28 in
    participants configuration
 +1/-1     
forking-1.0.10.yaml
Update forking example configuration                                         

examples/forking-1.0.10.yaml

  • Updated thornode-forking image version from 1.0.25 to 1.0.28 in
    participants section
 +1/-1     
forking-genesis.yaml
Update forking genesis example configuration                         

examples/forking-genesis.yaml

  • Updated thornode-forking image version from 1.0.25 to 1.0.28 in
    forking configuration
  • Updated image version in participants section
 +2/-2     
faucet_launcher.star
Update faucet launcher image version                                         

src/faucet/faucet_launcher.star

  • Updated thornode-forking image version from 1.0.25 to 1.0.28 for
    faucet service
 +1/-1     
single_node_launcher.star
Update single node launcher default image                               

src/network_launcher/single_node_launcher.star

  • Updated default thornode-forking image version from 1.0.25 to 1.0.28
 +1/-1     
thorchain_defaults.json
Update thorchain defaults image references                             

src/package_io/thorchain_defaults.json

  • Updated thornode-forking image version from 1.0.25 to 1.0.28 in
    participants configuration
  • Updated image version in forking configuration section
 +2/-2     
Dependencies
Dockerfile
Update Dockerfile base image version                                         

src/toolchain-cli/Dockerfile

  • Updated base image from thornode-forking 1.0.25 to 1.0.28
 +1/-1     

@coderabbitai

coderabbitai Bot commented Jan 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-thornode-1.0.28-23761879-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review

qodo-code-review Bot commented Jan 3, 2026

Copy link
Copy Markdown

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
⚪
Supply chain risk

Description: The PR updates to a third-party Docker image referenced only by a mutable tag (not pinned
to an immutable digest), which creates a supply-chain risk where the image content could
change without code review and introduce malicious or vulnerable binaries at build/run
time.
Dockerfile [1-1]

Referred Code 
FROM tiljordan/thornode-forking:1.0.28-23761879
Ticket Compliance
⚪
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review

qodo-code-review Bot commented Jan 3, 2026

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Avoid hardcoding the image version

Instead of hardcoding the faucet_image, retrieve it from the chain_cfg object to
ensure consistency with the node's forking image configuration.

src/faucet/faucet_launcher.star [32-33]

 # Use thornode forking image to get thornode CLI in container
-faucet_image = "tiljordan/thornode-forking:1.0.28-23761879"
+forking_config = chain_cfg.get("forking", {})
+faucet_image = forking_config.get("image", "tiljordan/thornode-forking:1.0.28-23761879")
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that the faucet_image is hardcoded, which can cause inconsistencies if a user specifies a custom image. Making it configurable by reading from chain_cfg improves robustness and aligns its behavior with other parts of the codebase, like single_node_launcher.star.

Medium
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tiljrd